ci: give "Merge Approved PR" a merge-method input #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
reviewed
Jan 12, 2026
| repo: context.repo.repo, | ||
| pull_number: ${{ inputs.pr-number }}, | ||
| merge_method: 'merge' | ||
| merge_method: '${{ inputs.merge-method }}' |
Member
There was a problem hiding this comment.
This should be provided as environment variable (as well as the PR number, though not strictly related to this PR).
Contributor
Author
There was a problem hiding this comment.
Oh sorry, actually I'm going to close this PR, we're going with a different solution to this issue
Contributor
Author
|
Going with a different solution to this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used in MetaMask/metamask-extension#39116
Note
Introduces a configurable merge strategy to the
merge-approved-pr.ymlworkflow.merge-methodinput (defaultmerge; supportsmergeorsquash) with validation inValidate Inputsmerge_method: '${{ inputs.merge-method }}'togithub.rest.pulls.mergeWritten by Cursor Bugbot for commit 58ce776. This will update automatically on new commits. Configure here.